Repository navigation
Fix crash traveling to Matataki through the town gate - #195
Merged
Adubbz merged 1 commit intoOct 20, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
|
Please do not change any of the /ps2 source files, all port-related code should be kept completely seperate from the PS2 version |
anxiousintrovert
force-pushed
the
codex/fix-191-matataki-gate
branch
from
October 19, 2026 13:13
d4816fb to
6900770
Compare
Adubbz
added a commit
that referenced
this pull request
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Matataki town-gate crash entirely in port code. No files under
ps2/are changed.The world-map script command retains its result destination as a native-width
RS_STACKDATA*in port-owned storage. A port wrapper publishes the selected map when the original town-menu handler completes. Unit-specific override aliases expose only the required command/menu state; original PS2 sources remain untouched.Validation (2026-10-19)
Based on current Chronicle master
6ec3b808. Clang Format, Clang Tidy and whitespace checks passed. Windows and Ubuntu builds completed. The reporter's PAL save and recorded 2200-tick town-gate route reached Matataki on Windows, Ubuntu and the Android x86-64 emulator; final screenshots were inspected. Android profile APK builds completed for ARM64 and x86-64. No physical Fold test was performed.Current Chronicle master pins Kazarov
611182d, which does not supply texture members used by current Chronicle. Kazarov main also changed audio and touch APIs. Local validation therefore used shared Kazarov main04bd301with test-only legacy-audio compatibility and Chronicle touch/link integration adjustments. Those unrelated adjustments are not included in this PR. The Windows run used Vulkan; Linux used llvmpipe. Android's host-GPU replay completed and saved its result, although the emulator later became unresponsive. No performance claim is made.Fixes #191.